Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Spline threading #1082
This PR enables nested threading mostly in the Spline SPO.
No performance impact if nested threading is not turned on.
referenced this pull request
Sep 21, 2018
I agree with docs and tests but I insist changing
The old output is actually misleading because it looks like printing environment variable but actually it is not. It is printing the number of available threads from the OpenMP runtime.
left a comment
I wouldn't insist on my changes but consider them.
I think this would be fine to go in now as an iteration of threaded spline support. Its helpful to look at how spline threading, batching, and perhaps small problems where we don't need this sort of threading can be accommodated. If there is even a performance hit on CPU evaluation of smaller problems.