Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setup python scripts 2/3 compatible #1261

Merged
merged 1 commit into from Dec 16, 2018

Conversation

markdewing
Copy link
Contributor

Use print function in performance adjustment script.
Use items rather than iteritems in test_labels.

Addresses #1256

Use print function in performance adjustment script.
Use items rather than iteritems in test_labels.
@ghost ghost assigned markdewing Dec 15, 2018
@ghost ghost added the in progress label Dec 15, 2018
@prckent
Copy link
Contributor

prckent commented Dec 16, 2018

For reference, please add your Summit build recipe here. gcc or xlc, which modules? The versions in the manual are updated after the acceptance related upgrades. I assume gcc since xlc and the modules don't make finding the C++ library convenient. Using the gcc route for verification

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked compatible between python2 and python3 on Summit. The anaconda provided python there should be consistent with other pythons on our other systems.

Of course this hints at wider issues. e.g. NEXUS is python2, we aren't controlling or testing our python environment.

@prckent prckent merged commit 3d842c2 into QMCPACK:develop Dec 16, 2018
@ghost ghost removed the in progress label Dec 16, 2018
@markdewing markdewing deleted the config_python23 branch August 16, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants