Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus: update for Cori #1463

Merged
merged 2 commits into from Mar 20, 2019

Conversation

Projects
None yet
3 participants
@jtkrogel
Copy link
Contributor

jtkrogel commented Mar 20, 2019

This PR contains modifications to handle the dual nature of Cori. Cori contains both Haswell and KNL nodes which effectively comprises two different machines from the point of view of job submission.

The updates allow the Cori supercomputer class to update its internal state relating to Haswell/KNL node anatomy when processing the job inputs prior to creating job submission scripts. I could have instead created two classes, e.g. CoriHaswell and CoriKNL, but this would preclude submission to both partitions from within the same Nexus script as is possible with the current modifications.

@qmc-robot

This comment has been minimized.

Copy link
Collaborator

qmc-robot commented Mar 20, 2019

Can one of the maintainers verify this patch?

@ye-luo

This comment has been minimized.

Copy link
Contributor

ye-luo commented Mar 20, 2019

Okay to test

@ye-luo

ye-luo approved these changes Mar 20, 2019

@ye-luo ye-luo merged commit 8e20d13 into QMCPACK:develop Mar 20, 2019

2 checks passed

rhea-cpu
Details
rhea-gpu
Details

@wafflebot wafflebot bot removed the in progress label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.