Skip to content

Update C-molecule performance test walker counts. #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

Hyeondeok-Shin
Copy link
Contributor

Proposed changes

This PR is a part of #4081 .
Update C-molecule performance test walker counts to more detailed performance check for the real simulation.
C-graphite performance test update will be followed with expanding its system size for the test. (Current graphite performance test has only one system size to check.)

What type(s) of changes does this code introduce?

  • Other (please describe): add test

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Intel Xeon

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • Yes. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

Copy link
Contributor

@ye-luo ye-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding batched_driver variants.

ye-luo
ye-luo previously approved these changes Jul 12, 2022
Copy link
Contributor

@ye-luo ye-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need non-ANL approval.

prckent
prckent previously approved these changes Jul 12, 2022
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks reasonable, but have not made a test run. Check the nightlies after merge.

@ye-luo ye-luo dismissed stale reviews from prckent and themself via 12b66b9 July 13, 2022 03:31
ye-luo
ye-luo previously approved these changes Jul 13, 2022
@ye-luo
Copy link
Contributor

ye-luo commented Jul 13, 2022

Test this please

@ye-luo ye-luo enabled auto-merge July 13, 2022 04:44
@ye-luo ye-luo merged commit 249b0b7 into QMCPACK:develop Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants