Skip to content

Fix offload when partial J1 is specified#4405

Merged
prckent merged 4 commits intoQMCPACK:developfrom
ye-luo:fix-batch-partialJ1
Jan 20, 2023
Merged

Fix offload when partial J1 is specified#4405
prckent merged 4 commits intoQMCPACK:developfrom
ye-luo:fix-batch-partialJ1

Conversation

@ye-luo
Copy link
Copy Markdown
Contributor

@ye-luo ye-luo commented Jan 20, 2023

Proposed changes

Make J1 with partial elements to work and issue warnings when it happens.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

Copy link
Copy Markdown
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prckent
Copy link
Copy Markdown
Contributor

prckent commented Jan 20, 2023

Test this please

@prckent prckent enabled auto-merge January 20, 2023 21:02
@prckent prckent merged commit 314c77e into QMCPACK:develop Jan 20, 2023
@ye-luo ye-luo deleted the fix-batch-partialJ1 branch January 21, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants