Skip to content

Remove xxx_unit cmake targets#4682

Merged
ye-luo merged 6 commits into
QMCPACK:developfrom
ye-luo:remove-unit
Jul 21, 2023
Merged

Remove xxx_unit cmake targets#4682
ye-luo merged 6 commits into
QMCPACK:developfrom
ye-luo:remove-unit

Conversation

@ye-luo

@ye-luo ye-luo commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

A big thank to @quantumsteve
No more redundant compilation of qmcham qmcdriver qmcestimators.
Closes #3700.

What type(s) of changes does this code introduce?

  • Build related changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc-server

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo

ye-luo commented Jul 21, 2023

Copy link
Copy Markdown
Contributor Author

Test this please

@prckent prckent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ye-luo ye-luo merged commit b85264d into QMCPACK:develop Jul 21, 2023
@ye-luo ye-luo deleted the remove-unit branch July 21, 2023 02:00
@prckent prckent mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of USE_FAKE_RNG macro

2 participants