Skip to content

Add docs on composing rotations - #4755

Merged
prckent merged 1 commit into
QMCPACK:developfrom
mdewing:orb_rot_compose_docs
Oct 5, 2023
Merged

Add docs on composing rotations#4755
prckent merged 1 commit into
QMCPACK:developfrom
mdewing:orb_rot_compose_docs

Conversation

@mdewing

@mdewing mdewing commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Add additional orbital rotation documentation describing the 'history' and 'global' rotation composition methods.

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • Documentation changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

laptop

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • N/A. Code added or changed in the PR has been clang-formatted
  • N/A. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • Yes. Documentation has been added (if appropriate)

@prckent

prckent commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Test this please

@prckent prckent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark

@prckent
prckent enabled auto-merge October 4, 2023 23:52
@prckent

prckent commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Note that there have been problems with rtd builds. Please can you check this PR makes it.

@prckent
prckent merged commit dace63f into QMCPACK:develop Oct 5, 2023
@mdewing
mdewing deleted the orb_rot_compose_docs branch October 6, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants