Skip to content

Nexus: enable driving spinor workflows - #4787

Merged
ye-luo merged 10 commits into
QMCPACK:developfrom
jtkrogel:nx_spinor_workflow
Dec 5, 2023
Merged

Nexus: enable driving spinor workflows#4787
ye-luo merged 10 commits into
QMCPACK:developfrom
jtkrogel:nx_spinor_workflow

Conversation

@jtkrogel

Copy link
Copy Markdown
Contributor

Proposed changes

Support generation of spinor inputs and driving of spinor workflows, including passing of u-u term from optimized collinear Jastrows. Orbitals currently handled at the level of existing hdf5 keyword (orbitals_h5). Full support for convertpw2qmc to be added later.

What type(s) of changes does this code introduce?

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Workstation

prckent
prckent previously approved these changes Nov 17, 2023
@prckent

prckent commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

Would like to merge but ntest_nexus_qmcpack_simulation is failing

@camelto2

camelto2 commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

I made a PR into Jaron's branch that fixes the failing unit test. It would be nice to have to merged before next weeks workshop because I would like to use this capability in the SOC tutorial

@prckent

prckent commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

@camelto2 If Jaron is busy, just push the fix here. Jaron will have to merge your PR into his branch for it to show up here.

We can only merge PRs that don't break the CI tests, otherwise the CI tests will be broken for everyone else. Once the CI passes this will be merged.

@camelto2

camelto2 commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

Hold off on this for now. Trying to actually use this in nexus and running into some issues. Will sort it out shortly

@camelto2

camelto2 commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

Hold off on this for now. Trying to actually use this in nexus and running into some issues. Will sort it out shortly

I think it is good to go now. I'm able to run successful, uninterrupted workflows using this now

@prckent prckent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved subject to CI.

( #4854 is queued up first )

@ye-luo

ye-luo commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

Test this please

@ye-luo
ye-luo enabled auto-merge December 5, 2023 19:03
@ye-luo
ye-luo merged commit 247067f into QMCPACK:develop Dec 5, 2023
@jtkrogel
jtkrogel deleted the nx_spinor_workflow branch November 19, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants