Fix spinors for orb opt

[camelto2]

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Orbital optimization with spinors had a few issues. First, RotatedSPOs were missing a few spin APIs. Second, once the appropriate APIs were added, there were some sizing issues when spinors were used with DiracDeterminants. This is because DD always passes in data structues sized nelec x nelec, whereas in the case of orb opt the spinorset has OrbitalSetSize > nelec. This is now fixed, and orb opt with spinors should be working

Unit tests were modified or added to in order to check both the missing spin APIs in RotatedSPOs as well as the sizing issues in SpinorSet.

What type(s) of changes does this code introduce?

Delete the items that do not apply

• Bugfix

Does this introduce a breaking change?

• No

What systems has this change been tested on?

M1 mac

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

• Yes. This PR is up to date with current the current state of 'develop'
• Yes. Code added or changed in the PR has been clang-formatted
• Yes. This PR adds tests to cover any new code, or to catch a bug that is being fixed
• No. Documentation has been added (if appropriate)

[ye-luo]

Test this please