Nexus: Print warning for the Nexus user before pwscf rsync - #4984
Merged
Conversation
prckent
changed the title
ye-luo
reviewed
May 12, 2024
| command = 'rsync -av {0}/* {1}/'.format(result.outdir,outdir) | ||
| if not os.path.exists(outdir): | ||
| print('Running rsync for the {} directory. This might take a while.'.format(outdir)) | ||
| os.makedirs(outdir) |
Contributor
There was a problem hiding this comment.
Please add a paired printout indicating the completion of rysnc.
Contributor
Author
There was a problem hiding this comment.
Done. Also moved the earlier print to just before the rsync. Makes more sense this way.
Contributor
There was a problem hiding this comment.
Please add back the printout before copy. They service distinct purpose and there is no harm to be verbose on the status of nexus. I misread your comment
Contributor
|
Test this please |
ye-luo
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When a new NSCF is located on a different path than SCF, Nexus will rsync the SCF results into the new path. This is a great feature for submitting multiple NSCF calculations with various k-points. However, this can take quite a while and can give the false sense that Nexus is hanging when, in fact, it is silently rsync'ing the results. This has confused me a few times.
I simply put two print statements warning the user that this is happening. It only executes the first time when the directory does not exist. There is probably a better way to output this - let me know if there is and I will be happy to update.
Does this introduce a breaking change?
What systems has this change been tested on?
All Nexus tests pass on my laptop (Linux Mint 21.3), except for 61/69 qdens_radial.
Checklist