Nexus: Updated PBS job states for Polaris#4987
Merged
Merged
Conversation
ye-luo
approved these changes
May 14, 2024
Contributor
|
Test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR updates the PBS scheduler available job states. Most important change from the older version PBS is the change of
completedtofinished. May 2020 version is installed in Polaris and it uses the new job state definitions. Without this update, it is not possible to use Nexus to submit jobs in Polaris because the state finished (F) is not defined. For compatibility in other computers still using the older version PBS, I have kept both completed and finished state tags.For reference, please see page RG-199 at https://2021.help.altair.com/2021.1/PBSProfessional/PBSReferenceGuide2021.1.pdf.
Here is the information from
man qstatin Polaris which has the matching information (select '1B' after man qstat):New tags in >2020 PBS version are B, F (replaced from C), M, U, X.
Nexus only uses the 'complete' status to track the jobs, therefore the rest of the status tags are there for bookkeeping:
qmcpack/nexus/lib/machines.py
Line 1307 in 1c17c0b
Does this introduce a breaking change?
What systems has this change been tested on?
Polaris
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.