Skip to content

Add build script for Improv at ANL LCRC - #4994

Merged
ye-luo merged 5 commits into
QMCPACK:developfrom
jtkrogel:build_improv
May 16, 2024
Merged

Add build script for Improv at ANL LCRC#4994
ye-luo merged 5 commits into
QMCPACK:developfrom
jtkrogel:build_improv

Conversation

@jtkrogel

Copy link
Copy Markdown
Contributor

Proposed changes

Enable builds on Improv at ANL's LCRC

What type(s) of changes does this code introduce?

  • Documentation or build script changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Improv

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@prckent prckent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not possible to module load boost etc. on this machine and avoid the extensive cmake line? Are they not setting the correct environment variables, making this extensive by-hand configuration necessary?

@jtkrogel

Copy link
Copy Markdown
Contributor Author

They do not have several of our needed dependencies available via module yet.

LCRC manages their system w/ Spack. The admins quickly built a module for QMCPACK via Spack and it was easiest for now just to use paths to the dependencies Spack built along the way.

I will continue to encourage them to make the dependencies available via modules.

Comment thread config/build_lcrc_improv.sh Outdated


CMAKE_FLAGS="-DENABLE_PPCONVERT=0 \
-DLAPACK_LIBRARIES=/gpfs/fs1/soft/improv/software/spack-built/linux-rhel8-zen3/gcc-13.2.0/openblas-0.3.26-blohgyt/lib/libopenblas.so \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loaded libflame but forcing openblas as the LAPACK?
Technically, amdblis is the BLAS and amdlibflame seems to be the LAPACK.
If you insist using openblas. Could you unload blis and flame?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

Comment thread config/build_lcrc_improv.sh Outdated
-DFFTW_LIBRARIES=/gpfs/fs1/soft/improv/software/spack-built/linux-rhel8-zen3/gcc-13.2.0/fftw-3.3.10-x5237xr/lib/libfftw3.so \
-DFFTW_INCLUDE_DIR=/gpfs/fs1/soft/improv/software/spack-built/linux-rhel8-zen3/gcc-13.2.0/fftw-3.3.10-x5237xr/include \
-DLIBXML2_INCLUDE_DIR=/gpfs/fs1/soft/improv/software/spack-built/linux-rhel8-zen3/gcc-13.2.0/libxml2-2.10.3-xkoaaap/include/libxml2 \
-DLIBXML2_LIBRARY=/gpfs/fs1/soft/improv/software/spack-built/linux-rhel8-zen3/gcc-13.2.0/libxml2-2.10.3-xkoaaap/lib/libxml2.so \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may set CMAKE_PREFIX_PATH as a CMake command-line option or environment variable.

SPACK_ROOT=/gpfs/fs1/soft/improv/software/spack-built/linux-rhel8-zen3/gcc-13.2.0
export CMAKE_PREFIX_PATH=$SPACK_ROOT/fftw-3.3.10-x5237xr:$SPACK_ROOT/libxml2-2.10.3-xkoaaap:$CMAKE_PREFIX_PATH

to avoid explicit setting both include and library by hand.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@jtkrogel

Copy link
Copy Markdown
Contributor Author

Comments addressed.

@ye-luo ye-luo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last request. Please rename the file to
build_anl_lcrc_improv.sh

Comment thread config/build_lcrc_improv.sh Outdated
export CMAKE_PREFIX_PATH=$SPACK_ROOT/fftw-3.3.10-x5237xr:$CMAKE_PREFIX_PATH
export CMAKE_PREFIX_PATH=$SPACK_ROOT/libxml2-2.10.3-xkoaaap:$CMAKE_PREFIX_PATH
export CMAKE_PREFIX_PATH=$SPACK_ROOT/hdf5-1.14.3-6qo7t6e:$CMAKE_PREFIX_PATH
export CMAKE_PREFIX_PATH=$SPACK_ROOT/openblas-0.3.26-blohgyt/lib:$CMAKE_PREFIX_PATH

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably lib is not needed.

@jtkrogel jtkrogel May 16, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Removed.

@jtkrogel

Copy link
Copy Markdown
Contributor Author

The file has been renamed. No issues remaining.

@prckent prckent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All previous comments addressed

@prckent

prckent commented May 16, 2024

Copy link
Copy Markdown
Contributor

Test this please

@ye-luo
ye-luo merged commit b3f19a0 into QMCPACK:develop May 16, 2024
@jtkrogel
jtkrogel deleted the build_improv branch November 19, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants