Add converter for determinants coming from a PySCF CAS-CI or CAS-SCF calculation. - #5005
Merged
Conversation
Contributor
|
Many thanks Amanda. The test fails locally for me too, so this is not some CI quirk: |
Contributor
|
Test this please |
prckent
self-requested a review
May 28, 2024 17:35
prckent
approved these changes
May 28, 2024
prckent
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me (LGTM)
I did a determinants only run to check the energy of the wavefunction ( 1000 blocks of 10000 steps, 48 walkers, 8 substeps, 0.5 timestep, 400 warmup) and got a good match:
LiH.pyscf.out:CASCI E = -7.98378359954454 E(CI) = -1.08000501124573 S^2 = 0.0000000
$qmca -q ev try.s000.scalar.dat
LocalEnergy Variance ratio
try series 0 -7.983708 +/- 0.000354 6.329815 +/- 0.471319 0.7928
Contributor
|
Test this please |
Contributor
|
Quick note that I did some tests filtering down to a single determinant. For this case the energy is still very close to the CASCI energy since the excited state determinants don't find much correlation energy in LiH. => It will be good to see this used in some more real world cases and know the energies match. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request extends the pyscf converter to support multideterminant wave functions coming from CAS-CI and CAS-SCF calculations.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Checklist
_Update the following with a yes where the items apply.