Add documentation and test for eigensolver option.#5006
Conversation
|
Test this please |
|
Do you want a deterministic test to check that the right code path is being followed? |
|
The second would work. |
|
It is hard to maintain optimization tests in deterministic tests. |
Check that the generalized eigensolver is chosen by checking for matching strings in the output.
|
Test this please |
|
Coverage uploads failed due to rate limits. |
|
The other option is to add "not safe with CPU mixed precision" to the passing regular expression list. Do you have a preference between this and guarding the CMake? |
|
Or, check the value of SUCCESS_STATUS_MP and set WILL_FAIL appropriately. That's probably the closest to the existing solution. |
|
The latter one (SUCCESS STATUS MP, WILL FAIL) seems simplest and also checks that the code bails as expected. |
|
Test this please |
|
Test this please |
Add a short test and documentation for the
eigensolveroption added in #4990 .The existing tests cover the default
inverseoption. The added test is a copy of optm-batch-OneShiftOnly-general.xml, but using thegeneraleigensolver.What type(s) of changes does this code introduce?
Delete the items that do not apply
Does this introduce a breaking change?
What systems has this change been tested on?
desktop
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.