updates to WalkerControl to have useful walker_ids#5089
Merged
Conversation
Contributor
|
Test this please |
PDoakORNL
force-pushed
the
walkerid_walkercontrol
branch
from
a8b0cca to
3221638
Compare
Contributor
Author
|
This is ready for review |
ye-luo
reviewed
Jul 22, 2024
| throw std::runtime_error("Potential bug! Population num_global_walkers mismatched!"); | ||
| #endif | ||
|
|
||
| // If we are in warmup it think it should be a fatal error is walker->Multiplicity != 1.0 |
Contributor
There was a problem hiding this comment.
DMC warmup follow normal branching. Only the first iteration flags do_not_branch.
| #include "type_traits/template_types.hpp" | ||
| #include "QMCWaveFunctions/TrialWaveFunction.h" | ||
|
|
||
| #include "Utilities/for_testing/NativeInitializerPrint.hpp" |
Contributor
There was a problem hiding this comment.
Either move it out of the test space as a generic feature or avoid using it.
Contributor
Author
There was a problem hiding this comment.
removing, sorry thought I'd pushed this.
ye-luo
reviewed
Jul 25, 2024
ye-luo
left a comment
ye-luo
left a comment
Contributor
There was a problem hiding this comment.
Please address the two remaining conversation. On a side note, I ran a DMC simulation and everything is fine.
Contributor
|
Test this please |
ye-luo
approved these changes
Jul 25, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Walker ID's in batched version of the drivers should now supply trackable walker ID's
supercedes #5010
What type(s) of changes does this code introduce?
Delete the items that do not apply
Does this introduce a breaking change?
What systems has this change been tested on?
OSX laptop
x86 build
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.