Nexus: Extend GCTA to SOC Calculations#5098
Merged
ye-luo merged 3 commits intoQMCPACK:developfrom Jul 29, 2024
Merged
Conversation
prckent
reviewed
Jul 23, 2024
Contributor
prckent
left a comment
There was a problem hiding this comment.
What did you test this on and how did you test it?
Contributor
Author
|
At this point I tested that it successfully generates the QMC inputs on fcc gold. I also tested that the previous collinear is intact by running |
prckent
approved these changes
Jul 28, 2024
Contributor
|
Test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously the grand-canonical twist-averaging (GCTA) implementation was hard-coded for collinear systems with spin up and down electrons only. This PR extends it to accept noncollinear systems for SOC calculations. It is mostly achieved by ignoring the down spin where necessary, similar to the qmcpack input.
I also fixed a minor bug (line 156), which erroneously asserted that normalization factor for k-points must be integer. This worked fine for even k-mesh grids, but errors out in odd k-mesh grids, as found by @camelto2 .
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Tested on OLCF/Andes using fcc Au system (only input generation using Nexus, no QMC runs).
Checklist