Skip to content

Nexus: Extend GCTA to SOC Calculations#5098

Merged
ye-luo merged 3 commits intoQMCPACK:developfrom
aannabe:nxs_gcta
Jul 29, 2024
Merged

Nexus: Extend GCTA to SOC Calculations#5098
ye-luo merged 3 commits intoQMCPACK:developfrom
aannabe:nxs_gcta

Conversation

@aannabe
Copy link
Copy Markdown
Contributor

@aannabe aannabe commented Jul 23, 2024

Proposed changes

Previously the grand-canonical twist-averaging (GCTA) implementation was hard-coded for collinear systems with spin up and down electrons only. This PR extends it to accept noncollinear systems for SOC calculations. It is mostly achieved by ignoring the down spin where necessary, similar to the qmcpack input.

I also fixed a minor bug (line 156), which erroneously asserted that normalization factor for k-points must be integer. This worked fine for even k-mesh grids, but errors out in odd k-mesh grids, as found by @camelto2 .

What type(s) of changes does this code introduce?

  • New feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Tested on OLCF/Andes using fcc Au system (only input generation using Nexus, no QMC runs).

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

Copy link
Copy Markdown
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did you test this on and how did you test it?

@aannabe
Copy link
Copy Markdown
Contributor Author

aannabe commented Jul 24, 2024

At this point I tested that it successfully generates the QMC inputs on fcc gold. I also tested that the previous collinear is intact by running nspin = 1 and nspin = 2 on gold. Similarly, Al and Fe collinear systems work without issues. Again, these tests were done only at Nexus level and by hand. It would be good to add some GCTA tests in future.

@prckent
Copy link
Copy Markdown
Contributor

prckent commented Jul 28, 2024

Test this please

@ye-luo ye-luo enabled auto-merge July 29, 2024 20:00
@ye-luo ye-luo merged commit 9df455b into QMCPACK:develop Jul 29, 2024
@aannabe aannabe deleted the nxs_gcta branch July 29, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants