Fix DLA+TMv1#5113
Merged
Merged
Conversation
PDoakORNL
approved these changes
Aug 6, 2024
PDoakORNL
left a comment
PDoakORNL
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me.
prckent
reviewed
Aug 7, 2024
prckent
left a comment
prckent
left a comment
Contributor
There was a problem hiding this comment.
LGTM also. Does this pass Andrea's test? Do we exactly reproduce the other implementations now or are there some remaining differences?
Contributor
Author
I didn’t do full range of tests but the reproducer I got seems producing the correct numbers. |
Contributor
Author
|
Test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The bug affects DLA+TMv1.
Tested and got consistent results with DLA+TMv0/1/3.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
bora
Checklist