Skip to content

make convert4qmc compatible with DIRAC versions > 22#5196

Merged
ye-luo merged 3 commits into
QMCPACK:developfrom
camelto2:update_dirac_parser
Oct 8, 2024
Merged

make convert4qmc compatible with DIRAC versions > 22#5196
ye-luo merged 3 commits into
QMCPACK:developfrom
camelto2:update_dirac_parser

Conversation

@camelto2
Copy link
Copy Markdown
Contributor

@camelto2 camelto2 commented Oct 7, 2024

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Updates converter to be compatible with DIRAC versions > 22.

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

mac

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@camelto2 camelto2 changed the title make convert4qmc compatible with DIRAC versions > 22 [WIP] make convert4qmc compatible with DIRAC versions > 22 Oct 7, 2024
@camelto2 camelto2 changed the title [WIP] make convert4qmc compatible with DIRAC versions > 22 make convert4qmc compatible with DIRAC versions > 22 Oct 7, 2024
@ye-luo
Copy link
Copy Markdown
Contributor

ye-luo commented Oct 7, 2024

Test this please

@ye-luo ye-luo enabled auto-merge October 7, 2024 22:46
@ye-luo ye-luo merged commit 0e0275b into QMCPACK:develop Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants