Initial SplineR2R offload#5198
Conversation
|
Test this please |
|
Test this please |
|
Test this please |
PDoakORNL
left a comment
There was a problem hiding this comment.
I feel like there is some coverage missing here that would be nice to have, although its in keeping with the spotty coverage throughout the SplineX2X files.
The missing coverage for
SplineR2R<ST>::mw_evaluateDetRatios()
and one of the legs of the
const ST signed_one = (bc_sign & 1) ? -1 : 1;
being my only real concern with this PR.
|
Test this please |
|
Test this please |
|
Test this please |
Both covered with the newly added unit test based on |
Proposed changes
Initial implementation.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist