Skip to content

Add an input consistency check.#5209

Merged
ye-luo merged 1 commit into
QMCPACK:developfrom
ye-luo:more-input-check
Nov 6, 2024
Merged

Add an input consistency check.#5209
ye-luo merged 1 commit into
QMCPACK:developfrom
ye-luo:more-input-check

Conversation

@ye-luo

@ye-luo ye-luo commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

No deterministic tests got flagged.

What type(s) of changes does this code introduce?

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

laptop

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted

Error out when user accidentally chooses fractional coordinates without specifying a lattice.
@ye-luo

ye-luo commented Nov 6, 2024

Copy link
Copy Markdown
Contributor Author

Test this please

@PDoakORNL PDoakORNL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ye-luo ye-luo merged commit e51f528 into QMCPACK:develop Nov 6, 2024
@ye-luo ye-luo deleted the more-input-check branch November 6, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants