Skip to content

Adding job completion message to convertpw4qmcpack - #5246

Merged
prckent merged 3 commits into
QMCPACK:developfrom
kayahans:develop
Nov 29, 2024
Merged

Adding job completion message to convertpw4qmcpack#5246
prckent merged 3 commits into
QMCPACK:developfrom
kayahans:develop

Conversation

@kayahans

@kayahans kayahans commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

Currently, convertpw4qmcpack gives no confirmation to the user if the conversion is successfully complete or not. I know the plan is to incorporate this code into pw2qmcpack, but for the short term this can be a reasonable solution.

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

  • ORNL-Baseline

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@prckent prckent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful improvement. I changed message to be the same style as the QMCPACK completion message (qmcapp.cpp:229). I also prefer we avoid use the term "job" since this is associated with queuing systems.

@prckent

prckent commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

Test this please

@prckent
prckent enabled auto-merge November 29, 2024 21:06
@prckent
prckent merged commit 3fff0a8 into QMCPACK:develop Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants