Adding job completion message to convertpw4qmcpack - #5246
Merged
Conversation
prckent
approved these changes
Nov 29, 2024
prckent
left a comment
Contributor
There was a problem hiding this comment.
Useful improvement. I changed message to be the same style as the QMCPACK completion message (qmcapp.cpp:229). I also prefer we avoid use the term "job" since this is associated with queuing systems.
Contributor
|
Test this please |
prckent
enabled auto-merge
November 29, 2024 21:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently, convertpw4qmcpack gives no confirmation to the user if the conversion is successfully complete or not. I know the plan is to incorporate this code into pw2qmcpack, but for the short term this can be a reasonable solution.
Does this introduce a breaking change?
What systems has this change been tested on?
Checklist