Set recompute period in performance tests to once every QMC section#5248
Merged
Conversation
Contributor
|
FYI. Just noticed that #4109 didn't touch batched drivers and the default for FP is 0. |
Contributor
Author
|
Will update this PR based on our discussion (one recompute per QMC section) and then check the defaults today. Good catch on 4109 -- it might explain a few of the oddities we have seen in large runs. Not all of them though. |
Contributor
Author
|
Also updated the NiO README |
ye-luo
approved these changes
Dec 3, 2024
Contributor
|
Test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Set the recompute periodic explicitly in the performance tests so that full & mixed precision builds do the same number of matrix inversions. (Mixed precision default is every block vs every 10 for full precision builds.) This changes addresses a couple of recent queries where the code has been profiled by users using the default settings.
Due to the few steps per block in the performance tests the existing settings result in a skew towards matrix inversion in profiles, performance analysis etc. In real/performance focused runs the number of steps per block would be larger than the e.g. 5 used for the DMC sections. A side effect is that some of the mixed precision performance tests will now show closer to real-world speedup.
Also added end of lines to a couple of the files for consistency.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
New mixed precision results should not be compared to old mixed precision results in terms of overall runtime.
What systems has this change been tested on?
gcc14 mpi nightly configuration, sulfur.
Checklist