[CMake] Introduce QMC_GPU cmake option#5267
Merged
Merged
Conversation
Contributor
Author
|
Test this please |
Concentrate user facing CMake options to QMC_GPU.
prckent
requested changes
Jan 7, 2025
Contributor
prckent
left a comment
There was a problem hiding this comment.
Thanks Ye.
While updating these config options, can you document USE_OBJECT_TARGET ? It is only mentioned in the CMakeLists.txt
Once this is in and working we should review and update the recipes in config/ to use QMC_GPU.
Contributor
Author
|
@prckent |
Contributor
|
Worth mentioning in https://github.com/QMCPACK/qmcpack/blob/develop/CHANGELOG.md |
prckent
approved these changes
Jan 7, 2025
Contributor
|
Test this please |
Contributor
|
Test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Replace
ENABLE_CUDA,ENABLE_ROCM,QMC_CUDA2HIP,ENABLE_SYCLandENABLE_OFFLOADCMake options with a single user facing optionQMC_GPUproposed in #5250What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist