Repository navigation
Nexus: Add GCTA docs and update examples - #5316
Merged
Merged
Conversation
Contributor
Author
|
Is there anything I could fix/improve in this PR? I have received a few questions regarding this Nexus feature, so I thought some documentation is needed. Please let me know. |
Contributor
|
I'll look this afternoon. |
Contributor
|
Test this please |
prckent
previously approved these changes
Feb 20, 2025
prckent
left a comment
prckent
left a comment
Contributor
There was a problem hiding this comment.
Many thanks Gani. LGTM.
Also appreciate the observables fix.
I took to opportunity to fix ESPRESSO throughout.
Q. Was there a reason other than convenience that you specified walkers_per_rank?
jtkrogel
reviewed
Feb 20, 2025
prckent
self-requested a review
February 20, 2025 19:34
Contributor
Author
Yes:
|
prckent
approved these changes
Feb 20, 2025
prckent
left a comment
prckent
left a comment
Contributor
There was a problem hiding this comment.
(Jaron reports PR looks good now via backchannel)
Contributor
|
Test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds Nexus documentation for GCTA added in #5029. I was not sure where to put it, so it is currently added at the end of "Nexus User Scripts".
Another minor fix in the documentation: error = 1/N -> error 1/sqrt(N) in CLT.
I also updated two Nexus examples, both of which are supposed to work with the now default batched driver (explicitly specified in
qmc_sharedobject asdriver = 'batched'). They were crashing due to the double specification of the driver.Also, the estimator example was initially intended for the batched driver input.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Local machine
Checklist