Nexus: magnetization density estimator - #5346
Merged
Merged
Conversation
prckent
requested changes
Mar 3, 2025
prckent
left a comment
Contributor
There was a problem hiding this comment.
Please add an example of using this to nexus/examples/qmcpack/rsqmc_misc/estimators/iron_ldaU_dmc.py . That example is the closest we have to documentation of what observables can be driven by NEXUS.
Contributor
|
Test this please |
prckent
enabled auto-merge
March 4, 2025 15:13
prckent
disabled auto-merge
March 4, 2025 15:29
Contributor
|
Small updates likely needed: |
Contributor
Author
|
@prckent sorry I realized that I had changed "simpson" to simpsons in the last commit, but realized that didn't make the change everywhere. The test now passes again: |
Contributor
|
Test this please |
ye-luo
approved these changes
Mar 4, 2025
ye-luo
enabled auto-merge
March 4, 2025 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add capability to define magnetizationdensity estimator in Nexus. Relevant nexus tests are also added.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
MacOS 15.3.1
Checklist