Suggest walker totals to achieve VMC load balance#5412
Merged
Conversation
ye-luo
reviewed
Apr 2, 2025
| app_warning() << "Walkers per rank (" << awc.walkers_per_rank[rank_id] << ") not divisible by number of crowds (" | ||
| << num_crowds << "). This will result in a loss of efficiency.\n"; | ||
|
|
||
| if (awc.global_walkers % num_ranks || awc.walkers_per_rank[rank_id] % num_crowds) |
Contributor
There was a problem hiding this comment.
awc.global_walkers % (num_ranks * num_crowds) instead?
Contributor
Author
There was a problem hiding this comment.
I prefer to copy the exact logic used in the lines above for consistency. i.e. If either of those warnings are triggered then this new printout clearly will be. Makes for easier reading.
Contributor
There was a problem hiding this comment.
I found the condition in the if statement wasn't aligned with the warning. I feel it should.
Actually, I misread the code.
ye-luo
approved these changes
Apr 2, 2025
Contributor
Author
|
Test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Help the user by suggesting a walker count that would be load balanced when imbalance is detected.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
sulfur, gcc14. A few by-hand MPI task and OpenMP thread count settings.
Checklist