Mention PR guidance in the PR template. - #5432
Merged
Merged
Conversation
prckent
previously approved these changes
Apr 10, 2025
prckent
left a comment
prckent
left a comment
Contributor
There was a problem hiding this comment.
Thanks Ye.
Clearly it will help longer term for us to have all guidance in the manual and not split between the wiki and manual.
I was also thinking that we could switch to yes/no questions in the template ("[x] I have read the pull request guidance and develop docs"), for faster editing.
Contributor
|
Test this please |
prckent
enabled auto-merge
April 10, 2025 18:07
Contributor
Author
Good suggestion and I like this idea. Let me just change it in this PR. |
ye-luo
disabled auto-merge
April 10, 2025 18:21
Contributor
Author
|
@prckent Updated. |
prckent
approved these changes
Apr 10, 2025
Contributor
|
Test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update PR template