Nexus: support orbital images XML element - #5448
Merged
Merged
Conversation
ye-luo
approved these changes
Apr 17, 2025
Contributor
|
Test this please |
ye-luo
enabled auto-merge
April 17, 2025 20:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Small update relating to legacy.
This PR adds support in Nexus to read/write the orbital images XML element in the input file. It also updates the xsf file reader class to handle the C-ordered xsf output produced by the orbital images code in legacy QMCPACK.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Workstation
Checklist