Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Creates many empty diffs #54

Closed
tobyS opened this Issue · 3 comments

2 participants

@tobyS
Owner

One of the recent changes introduced that refactorings might contain many empty diffs in addition to the relevant ones, see http://files.schlitt.info/tmp/diff_issues.patch.

To reproduce this diff do the following:

  1. Checkout https://github.com/Qafoo/changetrack revision 60a94df5c2d761f6af6ceb3ae9e0dd979f17a40a
  2. Move src/main/Qafoo/ChangeTrack/Analyzer/Vcs/GitCheckout.php -> src/main/Qafoo/ChangeTrack/Analyzer/Checkout/GitCheckout.php
  3. Execute refactor fix-class-names src/ test/ > diff_issues.patch

Btw. the intended changes do not occur in the diff at all.

@tobyS
Owner

@tomphp: I guess you are the right one to ping for a potential fix?

@tomphp

@tobyS I thinkt this should be pretty straight forward to fix, I'll take a look at it tomorrow.

@tomphp

This has been fixed in the PatchBuilder library, simply run composer update and the empty diffs should go away.

@tobyS tobyS closed this in 21027f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.