Creates many empty diffs #54

Closed
tobyS opened this Issue Jan 4, 2014 · 3 comments

Projects

None yet

2 participants

@tobyS

One of the recent changes introduced that refactorings might contain many empty diffs in addition to the relevant ones, see http://files.schlitt.info/tmp/diff_issues.patch.

To reproduce this diff do the following:

  1. Checkout https://github.com/Qafoo/changetrack revision 60a94df5c2d761f6af6ceb3ae9e0dd979f17a40a
  2. Move src/main/Qafoo/ChangeTrack/Analyzer/Vcs/GitCheckout.php -> src/main/Qafoo/ChangeTrack/Analyzer/Checkout/GitCheckout.php
  3. Execute refactor fix-class-names src/ test/ > diff_issues.patch

Btw. the intended changes do not occur in the diff at all.

@tobyS

@tomphp: I guess you are the right one to ping for a potential fix?

@tomphp

@tobyS I thinkt this should be pretty straight forward to fix, I'll take a look at it tomorrow.

@tomphp

This has been fixed in the PatchBuilder library, simply run composer update and the empty diffs should go away.

@tobyS tobyS added a commit that closed this issue Jan 5, 2014
@tobyS tobyS Fixed #54: Updated to most recent version of tomphp/patch-builder.
Thanks to @tomphp for fixing.
21027f3
@tobyS tobyS closed this in 21027f3 Jan 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment