Skip to content

Start breaking EditingSession down into EditingActions #48

merged 1 commit into from Jan 9, 2014

2 participants

tomphp commented Dec 27, 2013

This PR is the start of refactoring EditingSession.

Before continuing I'd like to know if you are happy with what I have done and what things I need to change.

One thing I'm not sure about is the location of IndentationDetector, maybe it should be in Services instead of Model?

Also I think it would be sensible to adopt using LineCollection (maybe rename it to Lines?) throughout the code base where ever string arrays of lines of code are passed into methods. In this case it would make sense for Line, LineCollection and IndentingLineCollection to exist in a more generic namespace than QafooLabs\Refactoring\Domain\Model. Thoughts and suggestions?

I look forward to some feedback.

@beberlei beberlei merged commit c951cbf into QafooLabs:master Jan 9, 2014

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.