Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin node and persistentVolume paginate select input change invalid #183

Merged
merged 3 commits into from Dec 26, 2018

Conversation

Projects
None yet
3 participants
@BennieMeng
Copy link
Collaborator

BennieMeng commented Dec 26, 2018

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind bug

What this PR does / why we need it:

fix paginate select change invalid, we should confirm the value must be a number.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@BennieMeng BennieMeng requested review from wilhelmguo and chengyumeng Dec 26, 2018

@wilhelmguo wilhelmguo changed the title fix: backend node persistentVolume paginate select input change invalid Fix admin node and persistentVolume paginate select input change invalid Dec 26, 2018

@wilhelmguo

This comment has been minimized.

Copy link
Collaborator

wilhelmguo commented Dec 26, 2018

LGTM

@chengyumeng chengyumeng merged commit 14c6e85 into Qihoo360:master Dec 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.