Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support Basic HPA In Frontend #207

Merged
merged 22 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@chengyumeng
Copy link
Collaborator

chengyumeng commented Jan 8, 2019

/kind feature

In this PR, I completed the development of most of the front-end user operations and completed some of the internationalization.

Considering that PR is already very bloated, the backend part hopes to implement it with another PR.

@chengyumeng chengyumeng requested a review from wilhelmguo Jan 8, 2019

wilhelmguo and others added some commits Jan 9, 2019

@wilhelmguo

This comment has been minimized.

Copy link
Collaborator

wilhelmguo commented Jan 9, 2019

@BennieMeng 看下前端代码

@wilhelmguo

This comment has been minimized.

Copy link
Collaborator

wilhelmguo commented Jan 9, 2019

@chengyumeng 后端管理还没有实现是么?

@chengyumeng

This comment has been minimized.

Copy link
Collaborator Author

chengyumeng commented Jan 10, 2019

@wilhelmguo 后端管理没有实现,准备分开做,不然周期太长代码太多了

Show resolved Hide resolved src/frontend/src/app/portal/autoscale/autoscale.component.ts Outdated
Show resolved Hide resolved ...tal/autoscale/create-edit-autoscale/create-edit-autoscale.component.html Outdated
Show resolved Hide resolved ...autoscale/create-edit-autoscaletpl/create-edit-autoscaletpl.component.ts Outdated
Show resolved Hide resolved src/frontend/src/app/portal/portal-routing.module.ts Outdated
}

} else if (actionType === ResourcesActionType.OFFLINE) {
this.title = `下线 ${this.resourceType} [` + resource.name + ']';

This comment has been minimized.

@BennieMeng

BennieMeng Jan 10, 2019

Collaborator

都用``来连接

This comment has been minimized.

@chengyumeng

chengyumeng Jan 10, 2019

Author Collaborator

没有必要都用的,的解释性能低于 '',使用 的原因是会传参。

Show resolved Hide resolved src/frontend/src/app/shared/model/v1/autoscaletpl.ts Outdated
Show resolved Hide resolved src/frontend/src/assets/i18n/zh-Hans.json

chengyumeng added some commits Jan 10, 2019

@chengyumeng

This comment has been minimized.

Copy link
Collaborator Author

chengyumeng commented Jan 10, 2019

@wilhelmguo @BennieMeng 代码已经按照 Review 修改完成,请关注下最新两个 commit

@BennieMeng
Copy link
Collaborator

BennieMeng left a comment

/LGTM

Show resolved Hide resolved src/frontend/src/assets/i18n/zh-Hans.json Outdated

@wilhelmguo wilhelmguo merged commit 134fb4e into Qihoo360:master Jan 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.