Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations to namespace in backend page #295

Merged
merged 12 commits into from Feb 21, 2019

Conversation

Projects
None yet
2 participants
@chengyumeng
Copy link
Collaborator

chengyumeng commented Feb 20, 2019

/kind feature

实现了表单中创建 ns 注解的功能

暂未实现高级模式编辑(可能需要较多调整)

chengyumeng added some commits Feb 20, 2019

Merge branch 'feature/namespace_annotations' of github.com:chengyumen…
…g/wayne into feature/namespace_annotations
@wilhelmguo

This comment has been minimized.

Copy link
Collaborator

wilhelmguo commented Feb 20, 2019

@chengyumeng 不是要做成类似于高级模式可以完全编辑metadata的形式么?

@chengyumeng

This comment has been minimized.

Copy link
Collaborator Author

chengyumeng commented Feb 20, 2019

@wilhelmguo 在 弹窗中弹出弹窗有问题。然后像 APP 那样元数据是一个框,感觉编辑起来不方便。

@wilhelmguo

This comment has been minimized.

Copy link
Collaborator

wilhelmguo commented Feb 20, 2019

@wilhelmguo 在 弹窗中弹出弹窗有问题。然后像 APP 那样元数据是一个框,感觉编辑起来不方便。

是需要做成那种像模版编辑一样,跳转一个页面,然后编辑元数据的时候再弹窗

@chengyumeng

This comment has been minimized.

Copy link
Collaborator Author

chengyumeng commented Feb 20, 2019

@wilhelmguo 你看一下要不要和其他资源的创建编辑统一一下,可以做成页面上可以相互切换的形式,其他的都是有个元数据的栏

@wilhelmguo

This comment has been minimized.

Copy link
Collaborator

wilhelmguo commented Feb 20, 2019

创建

这个比较特殊,因为要配置配额,直接编辑元数据不太方便,但是做成表单又不太灵活,所以要先把这个实现了

wilhelmguo added some commits Feb 20, 2019

@chengyumeng chengyumeng requested review from wilhelmguo and BennieMeng and removed request for wilhelmguo Feb 21, 2019

@wilhelmguo wilhelmguo merged commit 502a2dd into Qihoo360:master Feb 21, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.