Print more info when openapi meet a error #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengyumeng
added
kind/feature
wilhelmguo
reviewed
Feb 25, 2019
| logs.Error("Failed to get k8s deployment state: %s", err.Error()) | ||
| c.AddErrorAndResponse("", http.StatusInternalServerError) | ||
| logs.Error("Failed to get k8s deployment state", err.Error()) | ||
| c.AddErrorAndResponse("Failed to get k8s deployment state:the specified deployment may not exist in the kubernetes cluster.", http.StatusInternalServerError) |
There was a problem hiding this comment.
这里应该加判断区分错误返回不同的类型,而不是所有的都返回500
There was a problem hiding this comment.
@wilhelmguo kubernetes 的错误如何区分错误类型？
There was a problem hiding this comment.
| logs.Error("Failed to get k8s pod state: %s", err.Error()) | ||
| c.AddErrorAndResponse("", http.StatusInternalServerError) | ||
| logs.Error("Failed to get k8s pod state", err.Error()) | ||
| c.AddErrorAndResponse("Failed to get k8s pod state", http.StatusInternalServerError) |
chengyumeng
added
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用 OpenAPI 的时候，一些时候会输出一些含混不清的错误信息，例如：内部错误 等，这些错误没有明确表明用户在哪个环节出了错误，因此这个 PR 在这方面做了改进。
同时，优化了一些错误的声明方式，使之更加贴近 Go 建议的表达方式。主要在于，定义错误不要首字母大写，和输出错误信息要区别开。