Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-group curve analysis #824

Merged
merged 18 commits into from
Jul 11, 2022
Merged

Add multi-group curve analysis #824

merged 18 commits into from
Jul 11, 2022

Commits on Jun 9, 2022

  1. add multi group curve analysis class and update hamtomo analysis

    @nkanazawa1989
    nkanazawa1989 committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    a1be2e5 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. documentation update 

    Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>
    @nkanazawa1989 @eggerdj
    nkanazawa1989 and eggerdj committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    de42cd1 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. directly call protected methods of analysis instance. avoiding direct… 

    …ly calling _run_analysis can solve the issue of drawing, i.e. it gives back the control of drawer to composite instance. implementation is bit redundant since many method returns NotImplemented, but this will be solved by promoting CurveData to dataframe, where we can manage data blongs to different group in the same object. new standard analysis BlochTrajectoryAnalysis is added as a basis of CR hamiltonian analysis, which could be used outside the context of CR Hamiltonian.
    @nkanazawa1989
    nkanazawa1989 committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    32e0fcf View commit details
    Browse the repository at this point in the history

  2. fix test and docs

    @nkanazawa1989
    nkanazawa1989 committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    8515ef2 View commit details
    Browse the repository at this point in the history

  3. replace List with Dict

    @nkanazawa1989
    nkanazawa1989 committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    44cc681 View commit details
    Browse the repository at this point in the history

  4. revert redundant option

    @nkanazawa1989
    nkanazawa1989 committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    aa0beac View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. review comments 

    Co-authored-by: Will Shanks <wshaos@posteo.net>
    @nkanazawa1989 @wshanks
    nkanazawa1989 and wshanks committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    69cd9e9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/group_curve_analysis

    @nkanazawa1989
    nkanazawa1989 committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    9783884 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. move implementation to curve analysis

    @nkanazawa1989
    nkanazawa1989 committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    d3a5de4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/group_curve_analysis' of github.com:nkanazawa19… 

    …89/qiskit-experiments into feature/group_curve_analysis
    @nkanazawa1989
    nkanazawa1989 committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    623c972 View commit details
    Browse the repository at this point in the history

  3. minor comment fix

    @nkanazawa1989
    nkanazawa1989 committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    fca85b3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/group_curve_analysis

    @nkanazawa1989
    nkanazawa1989 committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    c242618 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. review comments and suggestions 

    Co-authored-by: Will Shanks <willshanks@us.ibm.com>
Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>
    @nkanazawa1989 @wshanks @eggerdj
    3 people committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    7f6424c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/group_curve_analysis' of github.com:nkanazawa19… 

    …89/qiskit-experiments into feature/group_curve_analysis
    @nkanazawa1989
    nkanazawa1989 committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    5cfafc1 View commit details
    Browse the repository at this point in the history

  3. more description for edge effect

    @nkanazawa1989
    nkanazawa1989 committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    7ae1d01 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/group_curve_analysis

    @nkanazawa1989
    nkanazawa1989 committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    30daad9 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2022

  1. Switch baseclass of composite curve analysis. Assuming user doesn't o… 

    …verride methods of composite analysis, since it just calls corresponding methods in analyses.
    @nkanazawa1989
    nkanazawa1989 committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    9b97df6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/group_curve_analysis' of github.com:nkanazawa19… 

    …89/qiskit-experiments into feature/group_curve_analysis
    @nkanazawa1989
    nkanazawa1989 committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    e48a9bb View commit details
    Browse the repository at this point in the history