New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move assignment of QuantumCircuit.measure to its class #1329

Closed
wants to merge 1 commit into
base: master
from

Conversation

@lukasszz
Contributor

lukasszz commented Nov 25, 2018

Small refactoring, for:

  • better code readability and navigation,
  • object design,
  • IDE support.

Summary

Details and comments

Move assignment of QuantumCircuit.measure to its class. Better object…
… design, code readability and IDE support.
@ajavadia

This comment has been minimized.

Member

ajavadia commented Nov 26, 2018

Hi. Let's hold off on this, as measure is only one of several methods added dynamically to the QuantumCircuit class (see reset and all files under qiskit.extensions.standard).

We have to address these together, and some redesign will be forthcoming.

For context this is related to #591.

@ajavadia

This comment has been minimized.

Member

ajavadia commented Dec 1, 2018

Closing this as measure is not inside QuantumCircuit after #1210. The underlying issue of dynamic function definitions is a whole separate issue that will be tackled for all gates.

@ajavadia ajavadia closed this Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment