New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measure() clearer message for args types cohesion check #1330

Merged
merged 3 commits into from Nov 26, 2018

Conversation

@lukasszz
Contributor

lukasszz commented Nov 25, 2018

Summary

Added better control for args type for the measure() function, to eliminate the common usage problem described in #915

@ajavadia

This comment has been minimized.

Member

ajavadia commented Nov 26, 2018

Thanks @lukasszz

@jaygambetta

I am going to approve as it is the same functionality that we already had but really the length of the cbit and qubit do not need to be the same.

@ajavadia ajavadia merged commit 4821f45 into Qiskit:master Nov 26, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lukasszz

This comment has been minimized.

Contributor

lukasszz commented Nov 29, 2018

Thanks @jaygambetta. If it goes about the length, I've just gone along current implementation. If you describe me the case when different length should be handled I can implement, providing tests of course.

@lukasszz lukasszz deleted the lukasszz:915_measure_arg_type_cohesion branch Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment