Skip to content
This repository was archived by the owner on Aug 21, 2023. It is now read-only.

Conversation

@quantumjim
Copy link
Member

Summary

Notebook using similar methods to the terrain generation notebook. This one has a method of loading images into states, manipulating them and producing animations.

Details and comments

Uses the PIL and apng packages, but I don't know if we want to add them into the environment necessarily.

Copy link
Member

@attp attp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You should link to this tutorial from your terrain generation one, as well as the games readme.
  • Is is possible to display the animations in the notebook as well as the still images?
  • I agree that the additional packages shouldn't be an environment requirement for qiskit or the tutorials.

@quantumjim
Copy link
Member Author

@attp Thanks for the feedback. I'll act on it soon.

@quantumjim quantumjim requested a review from jaygambetta as a code owner April 1, 2019 13:34
@quantumjim quantumjim requested a review from attp April 1, 2019 13:40
@quantumjim
Copy link
Member Author

@attp done!

Copy link
Member

@attp attp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Forgot to mention in my previous email that this is really cool!

@jaygambetta jaygambetta merged commit c39cc48 into master Apr 11, 2019
@jaygambetta jaygambetta deleted the quantumjim-patch-1 branch May 4, 2019 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants