New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set n_qubits for Aer simulators to max supported by local memory. #1369
Merged
diego-plan9
merged 25 commits into
Qiskit:master
from
nonhermitian:local_sim_num_qubits
Nov 29, 2018
Merged
Set n_qubits for Aer simulators to max supported by local memory. #1369
diego-plan9
merged 25 commits into
Qiskit:master
from
nonhermitian:local_sim_num_qubits
Nov 29, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 98e78d0.
nonhermitian
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
mtreinish and
taalexander
as code owners
November 29, 2018 02:15
can you activate the test that was disabled in #1327 |
jaygambetta
approved these changes
Nov 29, 2018
@nonhermitian lets wait for @diego-plan9 to review before merge |
diego-plan9
approved these changes
Nov 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @nonhermitian !
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
…skit#1369) * Fix parallezation in transpile.compile * Revert "Fix parallezation in transpile.compile" This reverts commit 98e78d0. * remove oops files * set Aer n_qubits based on local memory * turn on test removed in 1327 * remove unused import * set clifford simulator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #1156
Details and comments
Simple fix. However, additional work is needed to have the simulators check the
n_qubits
in the Qobj passed to the backend against these values.