Replace qiskit-card-item directive with simpler qiskit-card directive
#415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a slight difference. The card no longer takes up as much space. But it's pretty close. And it doesn't matter since we plan to switch to Furo anyways.
To avoid specificity wars, we now use div in front of the .qiskit-card class always
Eric-Arellano
added a commit
that referenced
this pull request
Jun 29, 2023
#415 accidentally broke `qiskit-card` being clickable. But the code wasn't accessible, to begin with. It's an antipattern to make a `<div>` clickable. Instead, we should use the semantic web with an `<a>` element. Pytorch renders the same as before: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
qiskit-card-item, we expected you to have raw HTML in your RST file with specific CSS classes so that everything would work correctly. That was an antipattern, and not necessary since a card is an independent visual unit that doesn't depend on its siblings.Now, users only specify
qiskit-cardin their RST.This PR also simplifies the HTML and CSS structure for the element:
tagsoption for the directive. It was unused in production.qiskit-card-x..card-bodythat won't exist in Furo.This will make #327 simpler.
Before:
After (my viewport changes a little):