Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set same value #68

Merged
merged 3 commits into from Aug 10, 2015

Conversation

@b-paul
Copy link
Contributor

commented Jul 25, 2015

Color objects are able to mutate even thought the values given are not different than existing ones, as in the following example:

var color = Color('#abc');
color.hexString(); // -> '#AABCC'
color.hue(color.hue()).hexString() // -> '#A9BACB'

I've added a new test, and a patch on Color.prototype.setChannel() that gets the test to pass.

@MoOx

This comment has been minimized.

Copy link
Collaborator

commented Aug 10, 2015

Hum weird. Thanks for the fix. I will try to cut a new release soon with immutable colors, cause mutation produce a lot of unexpected behavior (ref #56)

MoOx added a commit that referenced this pull request Aug 10, 2015

@MoOx MoOx merged commit ec55ede into Qix-:master Aug 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@b-paul b-paul deleted the b-paul:set-same-value branch Oct 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.