From 94db3e35655313f5de4abb7bc58cf47f66be629b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9mi=20Bonnet?= <rbonnet@qovery.com>
Date: Thu, 24 Nov 2022 15:08:23 +0100
Subject: [PATCH] fix(page-database): remove useless fetch

---
 libs/pages/database/src/lib/page-database.tsx | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/libs/pages/database/src/lib/page-database.tsx b/libs/pages/database/src/lib/page-database.tsx
index 2816d222f4..dbad38c0d1 100644
--- a/libs/pages/database/src/lib/page-database.tsx
+++ b/libs/pages/database/src/lib/page-database.tsx
@@ -1,10 +1,10 @@
+import equal from 'fast-deep-equal'
 import { Environment } from 'qovery-typescript-axios'
 import { useEffect } from 'react'
 import { useDispatch, useSelector } from 'react-redux'
 import { Route, Routes, useParams } from 'react-router-dom'
 import {
   databasesLoadingStatus,
-  fetchDatabase,
   fetchDatabaseMasterCredentials,
   fetchDatabaseMetrics,
   selectDatabaseById,
@@ -17,25 +17,28 @@ import { ROUTER_DATABASE } from './router/router'
 import Container from './ui/container/container'
 
 export function PageDatabase() {
-  useDocumentTitle('Database - Qovery')
   const { databaseId = '', environmentId = '' } = useParams()
   const environment = useSelector<RootState, Environment | undefined>((state) =>
     selectEnvironmentById(state, environmentId)
   )
-  const database = useSelector<RootState, DatabaseEntity | undefined>((state) => selectDatabaseById(state, databaseId))
+
+  const database = useSelector<RootState, DatabaseEntity | undefined>(
+    (state) => selectDatabaseById(state, databaseId),
+    equal
+  )
+
+  useDocumentTitle(`${database?.name || 'Database'} - Qovery`)
 
   const loadingStatus = useSelector<RootState, LoadingStatus>((state) => databasesLoadingStatus(state))
 
   const dispatch = useDispatch<AppDispatch>()
 
   useEffect(() => {
-    if (databaseId && loadingStatus === 'loaded') {
+    if (database && databaseId && loadingStatus === 'loaded') {
       database?.metrics?.loadingStatus !== 'loaded' && dispatch(fetchDatabaseMetrics({ databaseId }))
       database?.credentials?.loadingStatus !== 'loaded' && dispatch(fetchDatabaseMasterCredentials({ databaseId }))
-    } else {
-      dispatch(fetchDatabase({ databaseId }))
     }
-  }, [databaseId, loadingStatus])
+  }, [database && databaseId, loadingStatus])
 
   return (
     <Container database={database} environment={environment}>