From 5e9ca254ed9d68e8262b017beda4afc3fb0c5101 Mon Sep 17 00:00:00 2001 From: Romain Billard Date: Thu, 23 Apr 2026 11:15:24 +0200 Subject: [PATCH 1/5] Remove deprecated checkRunningStatusClosed query --- .../lib/domains-environments-data-access.ts | 10 +- .../environment-state-chip.tsx | 11 - .../use-check-running-status-closed.ts | 18 -- .../src/lib/domains-services-data-access.ts | 10 +- .../use-check-running-status-closed.ts | 19 -- .../select-commit-modal.spec.tsx.snap | 293 ------------------ .../select-commit-modal.spec.tsx | 37 ++- .../layout/src/lib/feature/layout/layout.tsx | 45 +-- .../use-status-web-sockets.ts | 19 -- 9 files changed, 61 insertions(+), 401 deletions(-) delete mode 100644 libs/domains/environments/feature/src/lib/hooks/use-check-running-status-closed/use-check-running-status-closed.ts delete mode 100644 libs/domains/services/feature/src/lib/hooks/use-check-running-status-closed/use-check-running-status-closed.ts delete mode 100644 libs/domains/services/feature/src/lib/select-commit-modal/__snapshots__/select-commit-modal.spec.tsx.snap diff --git a/libs/domains/environments/data-access/src/lib/domains-environments-data-access.ts b/libs/domains/environments/data-access/src/lib/domains-environments-data-access.ts index 05db8f3f683..ae34710c448 100644 --- a/libs/domains/environments/data-access/src/lib/domains-environments-data-access.ts +++ b/libs/domains/environments/data-access/src/lib/domains-environments-data-access.ts @@ -62,15 +62,7 @@ export const environments = createQueryKeys('environments', { ) }, }), - // TODO [To update once rust-backed will be deployed]: To remove - // NOTE: Value is set by WebSocket - checkRunningStatusClosed: (clusterId: string) => ({ - queryKey: [clusterId], - queryFn() { - // eslint-disable-next-line @typescript-eslint/no-empty-function - return new Promise<{ clusterId: string; reason: string }>(() => {}) - }, - }), + details: ({ environmentId }: { environmentId: string }) => ({ queryKey: [environmentId], async queryFn() { diff --git a/libs/domains/environments/feature/src/lib/environment-state-chip/environment-state-chip.tsx b/libs/domains/environments/feature/src/lib/environment-state-chip/environment-state-chip.tsx index 130d3a95b81..9d2e7ac784b 100644 --- a/libs/domains/environments/feature/src/lib/environment-state-chip/environment-state-chip.tsx +++ b/libs/domains/environments/feature/src/lib/environment-state-chip/environment-state-chip.tsx @@ -1,7 +1,5 @@ import { Skeleton, StatusChip, type StatusChipProps } from '@qovery/shared/ui' -import { useCheckRunningStatusClosed } from '../hooks/use-check-running-status-closed/use-check-running-status-closed' import { useDeploymentStatus } from '../hooks/use-deployment-status/use-deployment-status' -import { useEnvironment } from '../hooks/use-environment/use-environment' import { useRunningStatus } from '../hooks/use-running-status/use-running-status' /** @@ -45,16 +43,7 @@ function DeploymentStateChip({ environmentId, mode, ...props }: DeploymentStateC type RunningStateChipProps = Omit function RunningStateChip({ environmentId, ...props }: RunningStateChipProps) { - const { data: environment } = useEnvironment({ environmentId }) const { data: runningStatus } = useRunningStatus({ environmentId }) - const { data: checkRunningStatusClosed } = useCheckRunningStatusClosed({ - clusterId: environment?.cluster_id ?? '', - }) - - // TODO [To update once rust-backed will be deployed]: To remove - if (checkRunningStatusClosed) { - return - } return ( diff --git a/libs/domains/environments/feature/src/lib/hooks/use-check-running-status-closed/use-check-running-status-closed.ts b/libs/domains/environments/feature/src/lib/hooks/use-check-running-status-closed/use-check-running-status-closed.ts deleted file mode 100644 index 1628578a62c..00000000000 --- a/libs/domains/environments/feature/src/lib/hooks/use-check-running-status-closed/use-check-running-status-closed.ts +++ /dev/null @@ -1,18 +0,0 @@ -import { useQuery } from '@tanstack/react-query' -import { queries } from '@qovery/state/util-queries' - -export interface UseCheckRunningStatusClosedProps { - clusterId: string -} - -export function useCheckRunningStatusClosed({ clusterId }: UseCheckRunningStatusClosedProps) { - return useQuery({ - ...queries.environments.checkRunningStatusClosed(clusterId), - refetchOnMount: false, - refetchOnWindowFocus: false, - refetchOnReconnect: false, - staleTime: Infinity, - }) -} - -export default useCheckRunningStatusClosed diff --git a/libs/domains/services/data-access/src/lib/domains-services-data-access.ts b/libs/domains/services/data-access/src/lib/domains-services-data-access.ts index afc5f92374e..df008662721 100644 --- a/libs/domains/services/data-access/src/lib/domains-services-data-access.ts +++ b/libs/domains/services/data-access/src/lib/domains-services-data-access.ts @@ -224,15 +224,7 @@ export const services = createQueryKeys('services', { return new Promise(() => {}) }, }), - // TODO [To update once rust-backed will be deployed]: To remove - checkRunningStatusClosed: (clusterId: string, environmentId: string) => ({ - queryKey: [clusterId, environmentId], - // NOTE: Value is set by WebSocket - queryFn() { - // eslint-disable-next-line @typescript-eslint/no-empty-function - return new Promise<{ clusterId: string; environmentId: string; reason: string }>(() => {}) - }, - }), + metrics: (environmentId: string, serviceId: string) => ({ queryKey: [environmentId, serviceId], // NOTE: Value is set by WebSocket diff --git a/libs/domains/services/feature/src/lib/hooks/use-check-running-status-closed/use-check-running-status-closed.ts b/libs/domains/services/feature/src/lib/hooks/use-check-running-status-closed/use-check-running-status-closed.ts deleted file mode 100644 index 962c7be16e1..00000000000 --- a/libs/domains/services/feature/src/lib/hooks/use-check-running-status-closed/use-check-running-status-closed.ts +++ /dev/null @@ -1,19 +0,0 @@ -import { useQuery } from '@tanstack/react-query' -import { queries } from '@qovery/state/util-queries' - -export interface UseCheckRunningStatusClosedProps { - clusterId: string - environmentId: string -} - -export function useCheckRunningStatusClosed({ clusterId, environmentId }: UseCheckRunningStatusClosedProps) { - return useQuery({ - ...queries.services.checkRunningStatusClosed(clusterId, environmentId), - refetchOnMount: false, - refetchOnWindowFocus: false, - refetchOnReconnect: false, - staleTime: Infinity, - }) -} - -export default useCheckRunningStatusClosed diff --git a/libs/domains/services/feature/src/lib/select-commit-modal/__snapshots__/select-commit-modal.spec.tsx.snap b/libs/domains/services/feature/src/lib/select-commit-modal/__snapshots__/select-commit-modal.spec.tsx.snap deleted file mode 100644 index 1ca0f717eb2..00000000000 --- a/libs/domains/services/feature/src/lib/select-commit-modal/__snapshots__/select-commit-modal.spec.tsx.snap +++ /dev/null @@ -1,293 +0,0 @@ -// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing - -exports[`SelectCommitModal should match snapshot 1`] = ` -
-
-
-

- Deploy other version -

-

- Type a version to deploy -

- For X service -
-
-