Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with nested context manager. #207

Merged
merged 2 commits into from Sep 26, 2019
Merged

Fix error with nested context manager. #207

merged 2 commits into from Sep 26, 2019

Conversation

@hameerabbasi
Copy link
Contributor

hameerabbasi commented Sep 26, 2019

Fixes #206

@hameerabbasi hameerabbasi requested a review from peterbell10 Sep 26, 2019
@hameerabbasi hameerabbasi force-pushed the fix-nested branch 2 times, most recently from 4c19bbf to 24b7f84 Sep 26, 2019
@hameerabbasi

This comment has been minimized.

Copy link
Contributor Author

hameerabbasi commented Sep 26, 2019

It seems test_invalid is causing the segfault, even though it does pass. The Python process tries to decref something too much at one point, I think.

uarray/_uarray_dispatch.cxx Outdated Show resolved Hide resolved
uarray/_uarray_dispatch.cxx Outdated Show resolved Hide resolved
@hameerabbasi hameerabbasi force-pushed the fix-nested branch from 07444cc to 01fd49a Sep 26, 2019
@hameerabbasi hameerabbasi requested a review from peterbell10 Sep 26, 2019
uarray/_uarray_dispatch.cxx Outdated Show resolved Hide resolved
uarray/_uarray_dispatch.cxx Outdated Show resolved Hide resolved
uarray/_uarray_dispatch.cxx Outdated Show resolved Hide resolved
Co-Authored-By: peterbell10 <peterbell10@live.co.uk>
@hameerabbasi hameerabbasi merged commit ce82053 into master Sep 26, 2019
1 of 2 checks passed
1 of 2 checks passed
License Compliance FOSSA is analyzing this commit
Details
Quansight-Labs.uarray #20190926.7 succeeded
Details
@hameerabbasi hameerabbasi deleted the fix-nested branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.