Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LiveTradingRealTimeHandler pack-up creating the potential for a N… #4533

Merged
merged 1 commit into from Jun 23, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 23, 2020

…ullReferenceException

Description

Changes the order of pack-up in LiveTradingRealTimeHandler.Exit() to avoid a potential NullReferenceException.

Related Issue

Closes #4532

Motivation and Context

The exception was thrown in one of our environments and meant QC didn't pack-up cleanly. Functionality wasn't impacted, as QC was packing down anyway. However it still shouldn't be thrown.

Requires Documentation Change

N/A

How Has This Been Tested?

Test code was provided in the issue, showing how to reproduce the exception.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes. Reason: Unable to cover in a unit test.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thank you 👍

@Martin-Molinero Martin-Molinero merged commit 7687640 into QuantConnect:master Jun 23, 2020
@ghost ghost deleted the bug-4532-prevent-nullpointerexception-in-livetradingrealtimehandler branch July 22, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A NullReferenceException can occur in the IsolatorLimitResultProvider
1 participant