Bug #5030 Generation of CFD data not working

[jovuribe]

Description

Addressing issue #5030 with random generation of CFD data not working

In RandomDataGeneratorProgram.cs, var delistDate will produce a minValue greater than the maxValue at settings.Start.AddMonths(6) if the time difference between settings.Start and settings.End is less than 6 months. I addressed this issue by replacing this operation with a Datetime object that is halfway between settings.Start and settings.End.

Related Issue

https://github.com/QuantConnect/Lean/issues/5030

Motivation and Context

I spent some time working with Toolbox during the summer and this issue was brought to my attention. It solves an issue with random data generation for CFD data.

Requires Documentation Change

N/A

How Has This Been Tested?

I tested this on my private fork.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Refactor (non-breaking change which improves implementation)
• Performance (non-breaking change which improves performance. Please add associated performance test and results)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Non-functional change (xml comments/documentation/etc)

Checklist:

• My code follows the code style of this project.
• I have read the CONTRIBUTING document.
• [] I have added tests to cover my changes.
• Toolbox tests already exist. Ie. QuantConnect.Tests.Toolbox.RandomValueGenerator. Additionally, I attempted to reproduce the original bug on my private fork and no bugs occurred.
• All new and existing tests passed.
• My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

[Martin-Molinero]

Thanks for the test, almost there

[Martin-Molinero]

Thanks!