Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes/updates System.ComponentModel.Composition package #5257

Conversation

gsalaz98
Copy link
Contributor

@gsalaz98 gsalaz98 commented Feb 4, 2021

Description

Adds System.ComponentModel.Composition as an explicit packagereference include, for eventual migration to .NET Core/5.0.
The Composition namespace does not exist in .NET Core by default, but is provided as an extension package via NuGet. This installs that package.

Related Issue

.NET Core #452

Motivation and Context

Project modernization, .NET core

Requires Documentation Change

No

How Has This Been Tested?

Ran tests locally, tested local backtesting, tested cloud backtesting, research, live (IB/paper) for C#/Py

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Martin-Molinero Martin-Molinero merged commit fe1948d into master Feb 5, 2021
@Martin-Molinero Martin-Molinero deleted the refactor-update-system-componentmodel-composition-pkg-net-standard branch April 26, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants