Parameterless contructors for some CandleStickPatterns #569
Conversation
Update to last Lean:master
Rebase from QC
Rebase from QC
|
It's strange to see five merge commits as part of this PR. Not sure what happened. Ideally the PR would only include the new commits (the last two) |
|
Maybe is because I made merges instead of rebases. |
|
Have you had a look at the contributing.md? This document defines some good general practices for working with git. One key is that you always first refresh your origin and local master branches from QuantConnect, then perform changes on a new branch. Before submitting for a pull request, you can fetch and rebase your changes. This will help keep the source control history clean and understandable. |
|
Sorry for the mess. |
| /Algorithm.CSharp/NT | ||
| /Algorithm.CSharp/TrainingDataGenerator | ||
| /Tests/TrainingDataGenerator |
There was a problem hiding this comment.
Could you please revert the changes to this file?
| <ItemGroup /> | ||
| <ItemGroup> | ||
| <Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
No, I don't know.
There was a problem hiding this comment.
Seems to be generated by VS2013 when a projects contains tests:
http://stackoverflow.com/questions/18614342/what-is-service-include-in-a-csproj-file-for
http://www.alteridem.net/2014/10/16/visual-studio-2013-modifies-nunit-project-files/
We have the same line in QuantConnect.Tests.csproj which is a test project, probably it was added by VS in QuantConnect.Views.csproj because it now contains tests for the new DesktopClient.
|
Nice work @Jay-Jay-D, thanks for seeing it through to the end :) I squashed all the intermediate merges together. |
|
Thank you @jaredbroad @mchandschuh and @StefanoRaggi. |
|
No worries you should've seen some of my first commits on LEAN.. it read like this: |
Parameterless contructors added to AbandonedBaby, DarkCloudCover, EveningDojiStar, EveningStar, MatHold, MorningDojiStar and MorningStar.