Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warmup fixes #6293

Merged
merged 15 commits into from May 31, 2022
Merged

Warmup fixes #6293

merged 15 commits into from May 31, 2022

Conversation

Martin-Molinero
Copy link
Member

Description

  • Warmup data will now be provided by each own subscription
  • In live trading will use a file based and history provider warmup enumerators on each subscription
  • Universe selection and scheduled events now will work correctly during warmup

Related Issue

Closes #1046
Closes #4048
Closes #5262
Closes #5496
Closes #6263

Motivation and Context

Warmup behaves as expected

Requires Documentation Change

N/A

How Has This Been Tested?

Backtests and live deployments

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@jaredbroad jaredbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent review in slack.

@Martin-Molinero Martin-Molinero force-pushed the bug-6263-warmup-history branch 3 times, most recently from 8f05e1f to 7097bbb Compare May 26, 2022 18:08
@Martin-Molinero Martin-Molinero force-pushed the bug-6263-warmup-history branch 2 times, most recently from 2acfa06 to 5570cb9 Compare May 27, 2022 18:12
@Martin-Molinero Martin-Molinero merged commit e0b9a27 into master May 31, 2022
@Martin-Molinero Martin-Molinero deleted the bug-6263-warmup-history branch May 31, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants