Use one lean cli root folder per organization #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhonabreul
force-pushed
the
feat-one-lean-cli-root-folder-per-organization
branch
from
a8be77d
to
ce16a2b
Compare
Now using the organization id from the lean config
Now using the organization id from the lean config
jhonabreul
force-pushed
the
feat-one-lean-cli-root-folder-per-organization
branch
from
ce16a2b
to
bb2003d
Compare
jhonabreul
changed the title
jhonabreul
force-pushed
the
feat-one-lean-cli-root-folder-per-organization
branch
from
2663aed
to
ed14e80
Compare
Martin-Molinero
approved these changes
Nov 8, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes will make the CLI use the root
lean initfolder for a single organization:lean initin a single directory for each organization they belong to (and want to use the CLI with):lean.jsonfile and it will be used by every command that needs it (using theOrganizationManager, if possible).organization-idin thelean.jsonfile) will get a message informing them of the changes and what to do to keep using the CLI.Note: the check for existence of the organization id the lean config file on every command adds a small overhad of around 6ms, which is acceptable considering that it is expected to be removed in the near future.